Hello fellow trader warriors, I'm trying to program a sound alert. Here's my sample code.

 

Code

if(FirstTickOfBar) { if(Close[1]>Close[2]) PlaySound("Alert1.wav"); else if(Close[1]<Close[2]) PlaySound("Alert2.wav"); }

Let me say, I cannot hear a single cow bell this way

Is there something to add anywhere on my script to make it work ? Thank you

baberg 

Hello fellow trader warriors, I'm trying to program a sound alert. Here's my sample code.   Code if(FirstTickOfBar) { if(Close[1]>Close[2]) PlaySound("Alert1.wav"); else if(Close[1]<Close[2]) PlaySound("Alert2.wav"); } Let me say, I cannot hear a single cow bell this way Is there something to add anywhere on my script to make it work ? Thank you

The above code is correct, so I can only speculate. Please post the entire indicator next time, export via File -> Utilities -> Export NinjaScript.

The code references the bars CurrentBar - 1 and CurrentBar - 2 for the condition. When OnBarUpdate() starts its course, it will start with CurrentBar = 0, which is the first bar of the bar series. For the first bar you cannot reference prior bars, because they do not exist. NinjaTrader will therefore throw an exception and show it in the logs.

The correct way of doing it, is to only access the two prior bars starting with CurrentBar = 2, because now you have two prior bars that exist, the bars numbered 0 and 1. The modified code below should run.

 

Code

if(CurrentBar > 1 && FirstTickOfBar) { if(Close[1]>Close[2]) PlaySound("Alert1.wav"); else if(Close[1]<Close[2]) PlaySound("Alert2.wav"); }

Hello Fat Tails, you are correct. That was it. I always have a if(CurrentBar<1) return; at the beginning of my scripts just in case. I had only forgotten to put it at 2

Thanks mucho

baberg 

Hello Fat Tails, you are correct. That was it. I always have a if(CurrentBar<1) return; at the beginning of my scripts just in case. I had only forgotten to put it at 2 Thanks mucho

The "just in case" is dangerous, it really depends on the code. For some indicators you may want to write special instructions for (CurrentBar < period).