Code Syntax question

August 25th, 2014, 10:51 PM

I was just editing some code in a strategy (and much thanks go out to the coders)

I've noticed a lot of what I'd call unnessesary grouping parens, would someone look at this code and let me know if I shouldn't rewrite this:

Code

		if ( 
			(Historical)&&
			 (
			 (Instrument.FullName == "$USDJPY") || 
			 ( Instrument.FullName=="$GBPJPY" ) || 
			 ( Instrument.FullName=="$EURJPY" ) || 
			 ( Instrument.FullName=="$AUDJPY" ) || 
			 ( Instrument.FullName=="$NZDJPY")
			 )
			)

to this...?

Code

		if ( Historical &&
			(
			Instrument.FullName == "$USDJPY" || 
			Instrument.FullName == "$GBPJPY" || 
			Instrument.FullName == "$EURJPY" || 
			Instrument.FullName == "$AUDJPY" || 
			Instrument.FullName == "$NZDJPY"
			)
		)

...

Taking my first stab at C# but some syntax rules seem obvious to me, just wanna make sure I'm not F'*kin this up by applying standard syntax.

-Zx

August 26th, 2014, 12:08 AM

Zxeses

I was just editing some code in a strategy (and much thanks go out to the coders)

I've noticed a lot of what I'd call unnessesary grouping parens, would someone look at this code and let me know if I shouldn't rewrite this:

Code

		if ( 
			(Historical)&&
			 (
			 (Instrument.FullName == "$USDJPY") || 
			 ( Instrument.FullName=="$GBPJPY" ) || 
			 ( Instrument.FullName=="$EURJPY" ) || 
			 ( Instrument.FullName=="$AUDJPY" ) || 
			 ( Instrument.FullName=="$NZDJPY")
			 )
			)

to this...?

Code

		if ( Historical &&
			(
			Instrument.FullName == "$USDJPY" || 
			Instrument.FullName == "$GBPJPY" || 
			Instrument.FullName == "$EURJPY" || 
			Instrument.FullName == "$AUDJPY" || 
			Instrument.FullName == "$NZDJPY"
			)
		)

...

Taking my first stab at C# but some syntax rules seem obvious to me, just wanna make sure I'm not F'*kin this up by applying standard syntax.

-Zx

They are equivalent but your second version is much better, imho. (I'm guessing like you) I like to see parentheses in conditionals only when needed (i.e. for changing evaluation precedence or logical equivalence). It is an individual preference thang as well though, we all have different eyes.

Just as an aside, remember that '==' is fine if both sides are strings, otherwise you may need to use 'if (myThing.IsEquals("xxx")) instead if one isn't, rarer though.

Code Syntax question

Discussion in NinjaTrader

Code Syntax question