Ok, I'm stumped on this one.

Problem: Getting this error in my output window:

Quoting 

Error on calling 'OnBarUpdate' method for indicator 'DavesBidAskPriceLine' on bar 0: DavesBidAskPriceLine.DrawRay: anchor1BarsAgo out of valid range 0 through 0, was 100.

My debug output shows this:
BarCount: 14652 LineWidth: 100

Here is the code:

Quoting 

protected override void OnBarUpdate() { if (savedLastPrice==null) savedLastPrice = Close[0]; if (savedLastPrice == Close[0]) return; int LineWidth = Math.Min(Count, maxLineWidth); if (maxLineWidth==0 || LineWidth==0) { DrawRay("CurPriceLine", -1, Close[0], 0, Close[0], colorPriceLine); } else { Print("BarCount: " + Count + " LineWidth: " + LineWidth); DrawRay("CurPriceLine", LineWidth, Close[0], -1, Close[0], colorPriceLine); } savedLastPrice = Close[0]; ChartControl.ChartPanel.Invalidate(); }

When I manually set the LineWidth to zero in the Else section, it works (ray from 0 to -1)
I've even set it to -5 to -1 and that works...

In my OnMarketUpdate section, when I draw a Rectangle, this works fine... no problems:

Quoting 

else { DrawRectangle("AskPriceReg", true, LineWidth, askPriceStart, -1, askPriceEnd, Color.Empty, colorAskZone, 3); DrawRectangle("BidPriceReg", true, LineWidth, bidPriceStart , -1, bidPriceEnd, Color.Empty, colorBidZone, 3); }

Clearly from my debug output, there are enough bars, I would think 14k bars is enough, but it still errors with a setting anything above 0.

Here is the complete code for reference:

 

Code

namespace NinjaTrader.Indicator { [Description("A custom line price indicator that includes Bid/Ask data, and the ability to limit the size to just your current/recent chart so it doesnt show when reviewing historical data.")] public class DavesBidAskPriceLine : Indicator { #region Variables //Dictionary<double, long> rowsAsk = new Dictionary<double, long>(); //Dictionary<double, long> rowsBid = new Dictionary<double, long>(); Color colorAskZone = Color.DarkGreen; Color colorBidZone = Color.DarkBlue; Color colorPriceLine = Color.Orange; int maxLineWidth = 0; int maxBidAskWidth = 200; bool overlayLine = false; int opacityAsk = 10; int opacityBid = 10; double askPriceStart; double askPriceEnd; double bidPriceStart; double bidPriceEnd; double savedLastPrice; #endregion #region Initialize protected override void Initialize() { AutoScale = true; Overlay = true; CalculateOnBarClose = false; DisplayInDataBox = true; PaintPriceMarkers = false; DrawOnPricePanel = true; PlotsConfigurable = false; } #endregion #region MarketDepth protected override void OnMarketData(MarketDataEventArgs ev) { string dtype = ev.MarketDataType.ToString(); if (dtype!="Ask" && dtype!="Bid") return; //Print("ev.MarketDataType: " + ev.MarketDataType.ToString()); int LineWidth = Math.Min(Count, maxBidAskWidth); if (savedLastPrice==null || MarketData.Ask.Price != savedLastPrice && MarketData.Bid.Price != savedLastPrice) { // Set (or reset) everything; savedLastPrice = MarketData.Last.Price; askPriceStart=MarketData.Ask.Price; askPriceEnd=savedLastPrice; bidPriceStart=MarketData.Bid.Price; bidPriceEnd=savedLastPrice; } else { // Ask price change check if (MarketData.Ask.Price == savedLastPrice) { askPriceStart=MarketData.Ask.Price+(TickSize/2); askPriceEnd=savedLastPrice-(TickSize/2); } else { askPriceStart=MarketData.Ask.Price; askPriceEnd=savedLastPrice+(TickSize/2);; } // Bid price change check if (MarketData.Bid.Price == savedLastPrice) { bidPriceStart=MarketData.Bid.Price-(TickSize/2); bidPriceEnd=savedLastPrice+(TickSize/2); } else { bidPriceStart=MarketData.Bid.Price; bidPriceEnd=savedLastPrice-(TickSize/2); } } if (LineWidth==0) { DrawRectangle("AskPriceReg", true, -1, askPriceStart, Count, askPriceEnd, Color.Empty, colorAskZone, 3); DrawRectangle("BidPriceReg", true, -1, bidPriceStart, Count, bidPriceEnd, Color.Empty, colorBidZone, 3); // Removed to OnBarUpdate for compat with Index charts //DrawRay("CurPriceLine", -1, savedLastPrice, 2, savedLastPrice, colorPriceLine); } else { DrawRectangle("AskPriceReg", true, LineWidth, askPriceStart, -1, askPriceEnd, Color.Empty, colorAskZone, 3); DrawRectangle("BidPriceReg", true, LineWidth, bidPriceStart , -1, bidPriceEnd, Color.Empty, colorBidZone, 3); // Removed to OnBarUpdate for compat with Index charts //DrawRay("CurPriceLine", maxLineWidth, savedLastPrice, -1, savedLastPrice, colorPriceLine); } savedLastPrice = MarketData.Last.Price; ChartControl.ChartPanel.Invalidate(); } #endregion #region OnBarUpdate protected override void OnBarUpdate() { if (savedLastPrice==null) savedLastPrice = Close[0]; if (savedLastPrice == Close[0]) return; int LineWidth = Math.Min(Count, maxLineWidth); if (maxLineWidth==0 || LineWidth==0) { DrawRay("CurPriceLine", -1, Close[0], 0, Close[0], colorPriceLine); } else { Print("BarCount: " + Count + " LineWidth: " + LineWidth); DrawRay("CurPriceLine", LineWidth, Close[0], -1, Close[0], colorPriceLine); } savedLastPrice = Close[0]; ChartControl.ChartPanel.Invalidate(); } #endregion #region Properties [GridCategory("Settings")] [Gui.Design.DisplayName("Bar width (max.), 0 = Infinite")] public int MaxLineWidth { get { return maxLineWidth; } set { maxLineWidth = Math.Max(Math.Min(value, int.MaxValue), 0); } } [GridCategory("Settings")] [Gui.Design.DisplayName("Bid/Ask width")] public int MaxBidAskWidth { get { return maxBidAskWidth; } set { maxBidAskWidth = Math.Max(Math.Min(value, int.MaxValue), 0); } } #endregion } }

Any help would be appreciated

-Dave

Blah, nevermind, fixed it....

 

Code

protected override void OnBarUpdate() { if (CurrentBar < Count-1) return;

@Zxeses, Afaik, -1 is not a valid 'barsAgo' value in the parameters to the drawing calls, that should be part of the problem, as well as the number of bars needed that you already covered.

[e.g. if you want a horizontal ray off the last bar you would need to use 1 and 0, not 0 and -1.]

Glad I could help.
:P

ratfink 

@Zxeses, Afaik, -1 is not a valid 'barsAgo' value in the parameters to the drawing calls, that should be part of the problem, as well as the number of bars needed that you already covered. [e.g. if you want a horizontal ray off the last bar you would need to use 1 and 0, not 0 and -1.]

Well, -1 and -5 all work fine, indicator updated and posted :-)

Zxeses 

Well, -1 and -5 all work fine, indicator updated and posted :-)

Thanks for the info, I guess Ninja has lots of variations on 'valid' and 'unsupported'.