PriceActionSwing discussion

June 25th, 2022, 02:15 PM

traderpards

If I understand you correctly, then yes, you don't. Ninjatrader doesn't support inherited classes, sort of. You can put them on a chart but you can't put them in a strategy. I don't get it myself but I'm not them.

Then I need to add Abc and Fibonacci to the PriceActionSwingV2 and maybe call it Pro version V3

I have already added Div functionality

Kennet

June 25th, 2022, 03:54 PM

kennetstenberg

Then I need to add Abc and Fibonacci to the PriceActionSwingV2 and maybe call it Pro version V3

I have already added Div functionality

Kennet

That's what I would recommend for your own personal use. The original author has contacted me to upgrade his version to a better one, one that hopefully doesn't use inherited classes. When he does that, I will pull mine down so there aren't all these versions out there.

June 25th, 2022, 04:03 PM

traderpards

That's what I would recommend for your own personal use. The original author has contacted me to upgrade his version to a better one, one that hopefully doesn't use inherited classes. When he does that, I will pull mine down so there aren't all these versions out there.

Great
And you mean dorschden?

July 6th, 2022, 08:42 AM

How can I accomplish not having the indicator label print on the chart but still have the indicator name appear in the Configured list? When I blank out the indicator label in Properties, the indicator name in the Configured list is also blanked out.

I have several custom indicators that behave this way, so if there's a generic fix, I would appreciate knowing what edits to put in place. I am a neophyte/hack, so please include exactly what code and where to add or change.

July 6th, 2022, 12:18 PM

vickisb

How can I accomplish not having the indicator label print on the chart but still have the indicator name appear in the Configured list? When I blank out the indicator label in Properties, the indicator name in the Configured list is also blanked out.

I have several custom indicators that behave this way, so if there's a generic fix, I would appreciate knowing what edits to put in place. I am a neophyte/hack, so please include exactly what code and where to add or change.

Yeah, I haven't found a way to programmatically make it like you want. Only thing to do is just override DisplayName and return an abbreviated string that you can tell what it is and won't include all the crap that Ninjatrader puts on the chart.

Add it anywhere, just like another method but change "Shortened indicator name to something meaninful:

Code

        public override string DisplayName
        {
            get
            {
		return "Shortened indicator name";
            }
        }

And/or the user can just remove the label, save as a template and it will always load like that. (When you do that it doesn't remove the indicator name on the left side. That's what I do and it's fine.)

July 6th, 2022, 02:06 PM

traderpards

Yeah, I haven't found a way to programmatically make it like you want. Only thing to do is just override DisplayName and return an abbreviated string that you can tell what it is and won't include all the crap that Ninjatrader puts on the chart.

Add it anywhere, just like another method but change "Shortened indicator name to something meaninful:

Code

        public override string DisplayName
        {
            get
            {
		return "Shortened indicator name";
            }
        }

And/or the user can just remove the label, save as a template and it will always load like that. (When you do that it doesn't remove the indicator name on the left side. That's what I do and it's fine.)

That's the way it works on most of my custom indicators, but I have several (I do save a template with the label blanked out) where blanking out the label name in Properties blanks out the indicator name as well in the Configured list.

July 6th, 2022, 04:44 PM

vickisb

That's the way it works on most of my custom indicators, but I have several (I do save a template with the label blanked out) where blanking out the label name in Properties blanks out the indicator name as well in the Configured list.

If you think that's happening, you should ask Ninjatrader support about that then.

July 10th, 2022, 02:26 AM

vickisb

How can I accomplish not having the indicator label print on the chart but still have the indicator name appear in the Configured list? When I blank out the indicator label in Properties, the indicator name in the Configured list is also blanked out.

I have several custom indicators that behave this way, so if there's a generic fix, I would appreciate knowing what edits to put in place. I am a neophyte/hack, so please include exactly what code and where to add or change.

Hi
In order to have the indicator name appear in the indicator list, you set the name under State.SetDefaults, and you remove the name from the top of the chart under State.DataLoaded:

Code

protected override void OnStateChange()
		{
			if (State == State.SetDefaults)	
        {
          	Name = "BMTCollectiveMA"; //Sets the name in the list of indicators - see State == State.DataLoaded for removing from chart
			
        }
else if (State == State.DataLoaded) //See State == State.SetDefaults to set name so it appears in indicator list
            {			
				Name = "";
	     }

July 10th, 2022, 12:04 PM

GeorgeW

Hi
In order to have the indicator name appear in the indicator list, you set the name under State.SetDefaults, and you remove the name from the top of the chart under State.DataLoaded:

Code

protected override void OnStateChange()
		{
			if (State == State.SetDefaults)	
        {
          	Name = "BMTCollectiveMA"; //Sets the name in the list of indicators - see State == State.DataLoaded for removing from chart
			
        }
else if (State == State.DataLoaded) //See State == State.SetDefaults to set name so it appears in indicator list
            {			
				Name = "";
	     }

@vickisb The method above should work. But the fact you are messing with blanking the indicator name means you are likely using the original PriceActionSwing that can put a lot of stress on the system. The newer version using much less processing power:

Download: PriceActionSwingV2 & PriceActionSwingProV2

I've actually been working on this for years. At first, I just wanted to make it so the code was more readable so I could figure out what makes it tick. Dorschden's work is really an impressive effort IMO. But somewhere along the way, I learned that …

traderpards

July 24th, 2022, 01:41 PM

Hello,

Can someone please help me to understand how to add the market analyzer to priceactionswing indicator by dorchen into the market analyzer for NT8

PriceActionSwing discussion

Discussion in NinjaTrader

PriceActionSwing discussion