PriceActionSwingV2 link is dead on the download section, can someone share the file with me.

Thanks

@dorschden Thanks for the updates in the new version which I've just discovered in the last couple of days.

Would you consider hosting this indicator on GitHub so that people can contribute enhancements and fixes?

The reason I request this is because like many others I have made very extensive changes to to the indicator over the years and I am once again faced with the long and arduous task of re-integrating my changes with the new version. If it were hosted on Github we could fork your version to make our own changes and create pull requests for fixes and enhancements which you could review and accept into the master if you wish. It would also make it easy for us to merge your changes into our own branches.

By way of feedback on the new version, I don't think the new rendering method performs very well. Within the OnRender method, there are 4 calls to Find(). The find method operates by performing a full-scan of the respective collections. These 4 scans are done for every bar on the chart 4 times per second. And this is just to render the Zig-Zags.

Therefore in a scenario where you've got 300 bars visible and a history of 1000 swings. You are iterating:
4 x 4 x 300 x 1000 = 4,800,000 items per second

If you add just 4 more swings it becomes:
4 x 4 x 300 x 1004 = 4,819,200 items per second

So by adding just 4 more swings the number of items scanned has gone up by 19,200 PER SECOND! This is terribly inefficient code and will get exponentially slower and slower for every swing added. There will come a point pretty quickly where this implementation degrades. I find the performance to be quite poor - very sluggish when scrolling.

Back in 2018 I implemented an OnRender() method of my own which is significantly more efficient. But without anywhere to share my work ( and development on the original version seemingly abandoned ), I was the only person who benefited.

As well as performance issues, there are also bugs with the rendering: swings, naked swings and ABC patterns vanish when scrolled to the right.

I have already fixed these things and also halved the amount of code in OnRender and refactored a number of other things. So I'm proposing hosting on GitHub so that me and others like me can contribute our fixes and enhancements for your approval.

I welcome any feedback, comments and suggestions for improvement.

Please discuss the PriceActionSwing (PAS) indicator in this thread. Any comments or suggestions are more than welcome here. If you have a more private issue send me a PM or better an Email (you'll find the address in the top of the PriceActionSwingPro.cs script). Discussion about the newest version starts here (last update 31.08.2022).

Download PriceActionSwing

Market analyzer template
You can download a market analyzer template in this post. It contains ABC and divergence signals as well as swing trends and relations.

Versions

The PriceActionSwingPro indicator calculates swings in different ways and displays all kind of information about the swings above and below them. PriceActionSwingPro contains also some features:
- Draw automatically Fibonacci extensions and retracements
- naked swing lines
- Calculate a swing statistic
- Calculate and visualize ABC patterns
- Calculate and visualize divergence based on an indicator

Settings

Every setting in the NinjaTrades's indicator menu has a short description. Here is a short list of the more important ones.

Parameter:

Double top/-bottom strength:
Represents the double top/-bottom strength. Increase the value to get more double tops and -bottoms.

Swing size:
Represents the swing size. e.g. 1 = small swings and 5 = bigger swings. Which size you use depends on your trading style. There is no best setting for everybody.

Swing type:
Represents the swing type. In the "Standard" swing type a new swing is found when price is above or below the high or low of the last N bars and N = Swing size. The "Gann" type is calculated based on Gann's rules for swings.

Swing values:

Here you can choose which information the swings should display.
Information:
- Duration (in bars)
- Labels (HH, HL,…)
- Length (in ticks, points,…)
- Percentage (in relation to the last swing. e.g. 100% = DT/DB)
- Time
- Volume (Absolute and relative. Relative is the average volume per bar)

Swing visualization type:
Represents the swing visualization type. Dots | Zig-Zag lines | Dots and lines | Gann style. E.g. if you want only dots to visualize the swings choose "Dots".

Visualization:

Here you can choose your own look and feel for the visualization of the swings and the patterns.

Features:

Here you can turn the features on and off.

Statistics:
Swing Length shows the up and down swing length in ticks. The "Last Length" column is the average of the last N swings and N = "Statistic number of swings".

Swing relation for a specific swing (first column) the percentage amount of swings that follow this specific swing. E.g. the values of the first row (Higher High) are:
Swing Count Higher High Lower High Higher Low Lower Low
48 47,9% 52,1% 72,9% 22,9
Then you can interpret this as a Higher High is followed in 72,9% of all cases by a Higher Low and only in 22,9% by a Lower Low. 72,9% + 22,9 % = 95,8%. The remaining amount is for a double bottom.

Divergence:

Here you can set all settings to display divergences in the chart.

Div indicator:
Represents the indicator for the divergence calculations. You can add one or more indicators in the source code under the value "custom". Here you find instructions how to create divergence signals based on a freely chosen indicator.

Param1, Param2, Param3
Represents the first parameter for the indicator you choose. E.g. the standard MACD(12,26,9) would be
Param1 = 12
Param2 = 26
Param3 = 9.

The PAS indicator is very useful to see and trade pure price action with HH, HL in up trends and LL, LH in down trends and you can easily identify swing patterns like M, W, wedged, HS,…

NT7 statistic panel
[img]https://nexusfi.com/attachment.php?attachmentid=34431&stc=1&d=1300730439[/img]

Swing labels
[img]https://nexusfi.com/attachment.php?attachmentid=15050&d=1275941399[/img]


Any comments and suggestions are welcome!

Dorschden

Tip BEST OF TRADING 2011 AWARD PriceActionSwing was nominated for the Best Indicator Of The Year for 2011, and won 1st place (Gold).

Tip BEST OF TRADING 2010 AWARD PriceActionSwing was nominated for the Best Indicator Of The Year for 2010, and won 3rd place (Bronze).

You can see all the results here: Best Of Trading 2010 - Big Mike Trading